Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responsive and alignment issue on career/internship page #6009

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

upsaurav12
Copy link

Description

This PR fixes #5997
While working on this issue i have fixed the responsive issue of cards for mobile views(<450px).
Some issues were already fixed by someone else hence responsive issues on live website is not in local.

cinnamon-2024-10-19T2237210530.mp4

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@upsaurav12
Copy link
Author

upsaurav12 commented Oct 19, 2024

@vishalvivekm for careers/internship it is almost fixed.
but for the route campany/brand in local env that issue is not present as it is already fixed by someone. But i see some mis-alignment issues like the label of logo is not aligned , size of images are too larger for a mobile view.

cinnamon-2024-10-19T2250260530.mp4

@l5io
Copy link
Contributor

l5io commented Oct 19, 2024

🚀 Preview for commit 18e5679 at: https://6713eb85bf1db5f032b32bf6--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 20, 2024

🚀 Preview for commit af4b8ec at: https://6714a9bbc5a1569e8c49f1ad--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 20, 2024

🚀 Preview for commit c95b0a2 at: https://6714ecd2086477df19b795ea--layer5.netlify.app

@vishalvivekm
Copy link
Member

@upsaurav12
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Oct 21, 2024

🚀 Preview for commit 2b03cb9 at: https://67164cc98c4e2827597f2af9--layer5.netlify.app

@upsaurav12
Copy link
Author

image
@vishalvivekm In localhost i am getting this error in my local envirement(gitpod)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Responsive issues on Internship, brand pages of layer5
3 participants