Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated docs #759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ianrwhitney
Copy link

Notes for Reviewers

This PR fixes #
This PR helps clarify how to attach and run sistent repo in another project.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ian  whitney <[email protected]>
@@ -67,7 +67,8 @@ build:

```
attach sistent to your project:
npm install [path to sistent repo ]
npm pack (in sistent repo)
npm install /path/to/file.tgz (in another repo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you changing this path to specific ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wasnt able to get sistent to attach when running meshery with the given commands in the readme. I had to pack in a tgz file and then ask npm to install that. This was the only way it was able to attach. If the orginial works for you maybe i can add this as an alternative here? Let me know your thoughts. thanks for your time to comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nebula-aac, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants