Update process for user to change email #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When visiting the identity/emails/edit page the form would be shown even if the user was not verified. After fixing that, other problems appeared, related to the callback in the User model prematurely setting the verified status to false when submitting the form with an incorrect password. The solution was to use a before_update callback instead of before_validation. There was also no system test for a user attempting to change their email address but using the wrong password. Since that is related to this problem I have added that as well.
|
I've just opened an issue regarding the general problem... but it seems like the gem has the functionality now? |
|
This is the desired behaviour, we're following the they hey.com flow, the only reason users need to verify their email is to send pasword reset emails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When visiting the identity/emails/edit page the form would be shown even if the user was not verified. After fixing that, other problems appeared, related to the callback in the User model prematurely setting the verified status to false when submitting the form with an incorrect password. The solution was to use a before_update callback instead of before_validation.
There was also no system test for a user attempting to change their email address but using the wrong password. Since that is related to this problem I have added that as well.