Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Data/Fin): add @[simp] lemmas #22259

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(Data/Fin): add @[simp] lemmas #22259

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 25, 2025


Open in Gitpod

Copy link

github-actions bot commented Feb 25, 2025

PR summary af75a6e3d3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _
+ castSucc_pos_iff
+ val_eq_zero_iff
+ val_ne_zero_iff
+ val_pos_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@@ -251,17 +246,29 @@ This one instead uses a `NeZero n` typeclass hypothesis.
protected theorem zero_le' [NeZero n] (a : Fin n) : 0 ≤ a :=
Nat.zero_le a.val

@[simp, norm_cast]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to disable this @[simp] in the Imo2024Q5 file, so not sure if it should be a @[simp] lemma. CC: @kim-em

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant