Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(AlgebraicGeometry): clean up erw and porting notes #22272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vierkantor
Copy link
Contributor

I searched for erw and porting note and did my best to fix them. One recurring issue is that ext got less powerful than in Lean 3, the best solution is probably to make more @[ext] lemmas. But that would require more thought about library design than I have available right now.


Open in Gitpod

I searched for `erw` and `porting note` and did my best to fix them. One recurring issue is that `ext` got less powerful than in Lean 3, the best solution is probably to make more `@[ext]` lemmas. But that would require more thought about library design than I have available right now.
@Vierkantor Vierkantor added t-algebraic-geometry Algebraic geometry tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Feb 25, 2025
Copy link

PR summary c2c78bae5d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (20.56, 0.02)
Current number Change Type
3296 -22 porting notes
1283 -20 erw

Current commit c2c78bae5d
Reference commit 6d33eaf659

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebraic-geometry Algebraic geometry tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant