Clarify the download location of p2pd in setup.py #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xloem, thanks for the PR! The new commits are made into the master branch, could you please change the base of your PR and rebase your fix on top of that branch? |
xloem
force-pushed
the
clarifydownload
branch
from
dc4c835 to
8dd7cbf
Compare
|
rebased |
mryab
approved these changes
Nov 3, 2024
mryab
force-pushed
the
clarifydownload
branch
from
df80209 to
d34109e
Compare
mryab
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
On some systems,
urllibfails to make https connections unless certificates are installed in a certain place, or python is compiled a certain way, or thecertifipackage is installed, or a different package thanurllibis used to make the request, or most commonly certificate verification is disabled. This can deter installation of hivemind, because it requires downloading of an auxiliary file downloaded with urllib during install.I didn't immediately find information on troubleshooting the issue, although I have encountered it before. It ended up being easier for me to manually download the file, but I had to inspect the setup.py source to see where to place it.
This patch modifies the log message so that the user can easily see what path the file is being downloaded to.