Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo leptos build fails, fixed issue for macos, which always builds into target/aarch64-apple-darwin #422

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

holg
Copy link
Contributor

@holg holg commented Jan 22, 2025

cargo leptos build fails, fixed issue for macos, which always builds into target/aarch64-apple-darwin
The issue here, as well as for cross-platform builds, is:
on macos the binary is alwasy put into target/aarch64[|x86_64]/
thus the binary later is not found.
I already made a fix, but it failed some tests, sorry!
Now i made the fix differently, to always add the target directly in the config.
The tests needed to be adapted to be more dynamic, as the target_triple is variable.
Have as well a look onto
fix issue #358 #359
in which @gbj rightfully complained about the kind of the fix.
So it shall be OK now.

Holger Trahe and others added 8 commits September 1, 2024 17:09
Merged upstream main into dev

# Conflicts:
#	Cargo.lock
#	Cargo.toml
added filters feature to insta test,
patched the tests to accept the target output of the changed bin_packageAdd platform-based target handling and test filters.

Ensure the build target defaults to the current platform when unspecified, and add the "filters" feature to Insta for consistent test snapshots. Update tests to accommodate platform-specific output and adjust bin package logic for accurate file detection.
…added accordingly, be it in bin_package.rs or project.rs, so the args are correctly pushed into server.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant