Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PatchField for Option #3528

Merged
merged 4 commits into from
Feb 1, 2025
Merged

Implement PatchField for Option #3528

merged 4 commits into from
Feb 1, 2025

Conversation

iradicek
Copy link
Contributor

@iradicek iradicek commented Jan 30, 2025 •
edited
Loading

Adding implementation of PatchField (in reactive_stores) for Option<T>.

@iradicek iradicek marked this pull request as draft January 30, 2025 21:18
@iradicek iradicek marked this pull request as ready for review January 30, 2025 23:07
@iradicek
Copy link
Contributor Author

Workflows failed previously. I think it should be fixed by rebasing the branch (since semver check failed for a type I did not touch), not sure though.

@gbj
Copy link
Collaborator

gbj commented Feb 1, 2025

Thanks!

@gbj gbj merged commit 32be3a0 into leptos-rs:main Feb 1, 2025
74 checks passed
@iradicek iradicek deleted the ir/patch-field-option branch February 1, 2025 15:02
zakstucke pushed a commit to zakstucke/leptos that referenced this pull request Feb 6, 2025
@iradicek @zakstucke
feat: implement PatchField for Option<_> (leptos-rs#3528)
d75f474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iradicek @gbj