Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows non static lifetimes in component macro #3571

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Allows non static lifetimes in component macro #3571

merged 2 commits into from
Feb 11, 2025

Conversation

jvdwrf
Copy link
Contributor

@jvdwrf jvdwrf commented Feb 9, 2025

closes #3564

@gbj
Copy link
Collaborator

gbj commented Feb 9, 2025 •
edited
Loading

Thanks! Lints are failing in CI because lifetimes is now unused

https://github.com/leptos-rs/leptos/pull/3571/files#diff-b9296cfcac1405d1762fdf9c46507fac8eb7f8618d234d40498294a18be04e5cL147

@jvdwrf
Copy link
Contributor Author

jvdwrf commented Feb 10, 2025

Ah thanks, It should be fixed now with the new commit

@gbj gbj merged commit b17a4c9 into leptos-rs:main Feb 11, 2025
74 checks passed
@jvdwrf jvdwrf deleted the allow-non-static-lifetimes-in-component-macro branch February 11, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Components with arguments passed by reference
2 participants
@jvdwrf @gbj