Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing <fieldset> attributes #3581

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

alexisfontaine
Copy link
Contributor

@benwis
Copy link
Contributor

benwis commented Feb 10, 2025

@alexisfontaine This seems fine, did you try to use these with attribute spreading? attr:name=blah? Still happy to merge it, just curious

@alexisfontaine
Copy link
Contributor Author

Attributes spreading does works on a component wrapping a native <fieldset>. Although I prefer view!(<fieldset {..disabled(true)} />), or the equivalent builder syntax fieldset().add_any_attr(disabled(true)).

@benwis
Copy link
Contributor

benwis commented Feb 10, 2025

Thanks!

@benwis benwis merged commit 03f9c6c into leptos-rs:main Feb 10, 2025
74 checks passed
@alexisfontaine alexisfontaine deleted the fix/fieldset_attributes branch February 10, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants