fix: no panic after on defaultNamifier (#236)

Co-authored-by: Nick Chen <[email protected]>
lerenn · Jun 20, 2024 · ba075d6 · ba075d6
1 parent b5810b7
commit ba075d6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/pkg/utils/template/helpers.go b/pkg/utils/template/helpers.go
@@ -61,6 +61,9 @@ func DefaultNamifier(sentence string) string {
 	// Remove leading numbers
 	re = regexp.MustCompile("^[0-9]+")
 	sentence = string(re.ReplaceAll([]byte(sentence), []byte("")))
+	if len(sentence) == 0 {
+		return sentence
+	}
 
 	// Upper first letter
 	sentence = strings.ToUpper(sentence[:1]) + sentence[1:]

diff --git a/pkg/utils/template/helpers_test.go b/pkg/utils/template/helpers_test.go
@@ -22,6 +22,10 @@ type namifyCases struct {
 var namifyBaseCases = []namifyCases{
 	// Nothing
 	{In: "", Out: ""},
+	// new line
+	{In: "\n", Out: ""},
+	// just numbers
+	{In: "00", Out: ""},
 	// Remove leading digits
 	{In: "0name0", Out: "Name0"},
 	// Remove non alphanumerics