Better typing (response class and issue with .get
, .post
, ...)
#490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two things:
In my previous PR to make the methods
.get
,.post
,.put
, ..., I forgot to addtotal=False
in theTypedDict
they were unpacking, which was getting the type hint to sayAny
.A type hint for the response class. The results of requests were always an object
Response
, even if theresponse_class
was changed. Now, if theresponse_class
argument is set, the result hint will be an instance of this argument. Here is what it does: