Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: withdrawal credentials #904

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
+1,698 −35

feat: update eip-7002 contract address

c27de34
Select commit
Loading
Failed to load commit list.
Open

feat: withdrawal credentials #904

feat: update eip-7002 contract address
c27de34
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither succeeded Feb 4, 2025 in 3s

2 new alerts including 2 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 2 medium

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 188 in contracts/0.8.9/WithdrawalVault.sol

See this annotation in the file changed.

Code scanning / Slither

Divide before multiply Medium

WithdrawalVault.addFullWithdrawalRequests(bytes) performs a multiplication on the result of a division:
- totalFee = (pubkeys.length / TriggerableWithdrawals.PUBLIC_KEY_LENGTH) * minFeePerRequest

Check warning on line 188 in contracts/0.8.9/WithdrawalVault.sol

See this annotation in the file changed.

Code scanning / Slither

Dangerous strict equalities Medium

WithdrawalVault.addFullWithdrawalRequests(bytes) uses a dangerous strict equality:
- assert(bool)(address(this).balance == prevBalance)