[SI][Vaults] feat: Dashboard UX updates

contracts/0.8.25/interfaces/ILido.sol

@@ -16,6 +16,8 @@ interface ILido is IERC20, IERC20Permit {
 
     function transferSharesFrom(address, address, uint256) external returns (uint256);
 
+    function transferShares(address, uint256) external returns (uint256);
+
     function rebalanceExternalEtherToInternal() external payable;
 
     function getTotalPooledEther() external view returns (uint256);

contracts/0.8.25/vaults/Delegation.sol

@@ -27,7 +27,6 @@ import {Dashboard} from "./Dashboard.sol";
  * The unclaimed fee is the amount of ether that is owed to the curator or node operator based on the feeBP.
  */
 contract Delegation is Dashboard {
-
     /**
      * @notice Maximum combined feeBP value; equals to 100%.
      */
@@ -112,11 +111,10 @@ contract Delegation is Dashboard {
     /**
      * @notice Constructs the contract.
      * @dev Stores token addresses in the bytecode to reduce gas costs.
-     * @param _stETH The address of the stETH token.
      * @param _weth Address of the weth token contract.
-     * @param _wstETH Address of the wstETH token contract.
+     * @param _lidoLocator Address of the Lido locator contract.
      */
-    constructor(address _stETH, address _weth, address _wstETH) Dashboard(_stETH, _weth, _wstETH) {}
+    constructor(address _weth, address _lidoLocator) Dashboard(_weth, _lidoLocator) {}
 
     /**
      * @notice Initializes the contract:
@@ -199,7 +197,7 @@ contract Delegation is Dashboard {
      * @notice Funds the StakingVault with ether.
      */
     function fund() external payable override onlyRole(FUND_WITHDRAW_ROLE) {
-        _fund();
+        _fund(msg.value);
     }
 
     /**
@@ -227,11 +225,11 @@ contract Delegation is Dashboard {
      * @param _recipient The address to which the shares will be minted.
      * @param _amountOfShares The amount of shares to mint.
      */
-    function mint(
+    function mintShares(
         address _recipient,
         uint256 _amountOfShares
     ) external payable override onlyRole(MINT_BURN_ROLE) fundAndProceed {
-        _mint(_recipient, _amountOfShares);
+        _mintSharesTo(_recipient, _amountOfShares);
     }
 
     /**
@@ -241,8 +239,8 @@ contract Delegation is Dashboard {
      * NB: Delegation contract must have ERC-20 approved allowance to burn sender's shares.
      * @param _amountOfShares The amount of shares to burn.
      */
-    function burn(uint256 _amountOfShares) external override onlyRole(MINT_BURN_ROLE) {
-        _burn(_amountOfShares);
+    function burnShares(uint256 _amountOfShares) external override onlyRole(MINT_BURN_ROLE) {
+        _burnSharesFrom(msg.sender, _amountOfShares);
     }
 
     /**

contracts/0.8.9/Burner.sol

@@ -244,9 +244,9 @@ contract Burner is IBurner, AccessControlEnumerable {
         if (_amount == 0) revert ZeroRecoveryAmount();
         if (_token == address(LIDO)) revert StETHRecoveryWrongFunc();
 
-        emit ERC20Recovered(msg.sender, _token, _amount);
-
         IERC20(_token).safeTransfer(LOCATOR.treasury(), _amount);
+
+        emit ERC20Recovered(msg.sender, _token, _amount);
     }
 
     /**
@@ -259,9 +259,9 @@ contract Burner is IBurner, AccessControlEnumerable {
     function recoverERC721(address _token, uint256 _tokenId) external {
         if (_token == address(LIDO)) revert StETHRecoveryWrongFunc();
 
-        emit ERC721Recovered(msg.sender, _token, _tokenId);
-
         IERC721(_token).transferFrom(address(this), LOCATOR.treasury(), _tokenId);
+
+        emit ERC721Recovered(msg.sender, _token, _tokenId);
     }
 
     /**

scripts/scratch/steps/0145-deploy-vaults.ts

@@ -12,8 +12,7 @@ export async function main() {
   const state = readNetworkState({ deployer });
 
   const accountingAddress = state[Sk.accounting].proxy.address;
-  const lidoAddress = state[Sk.appLido].proxy.address;
-  const wstEthAddress = state[Sk.wstETH].address;
+  const locatorAddress = state[Sk.lidoLocator].proxy.address;
 
   const depositContract = state.chainSpec.depositContract;
   const wethContract = state.delegation.deployParameters.wethContract;
@@ -27,9 +26,8 @@ export async function main() {
 
   // Deploy Delegation implementation contract
   const delegation = await deployWithoutProxy(Sk.delegationImpl, "Delegation", deployer, [
-    lidoAddress,
     wethContract,
-    wstEthAddress,
+    locatorAddress,
   ]);
   const delegationAddress = await delegation.getAddress();
 

test/0.8.25/vaults/contracts/WETH9__MockForVault.sol

@@ -3,8 +3,6 @@
 
 pragma solidity 0.4.24;
 
-import {StETH} from "contracts/0.4.24/StETH.sol";
-
 contract WETH9__MockForVault {
     string public name = "Wrapped Ether";
     string public symbol = "WETH";

test/0.8.25/vaults/dashboard/contracts/ERC721_MockForDashboard.sol

@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: UNLICENSED
+// for testing purposes only
+
+pragma solidity 0.8.25;
+
+import {ERC721} from "@openzeppelin/contracts-v5.2/token/ERC721/ERC721.sol";
+
+contract ERC721_MockForDashboard is ERC721 {
+    constructor() ERC721("MockERC721", "M721") {}
+
+    function mint(address _recipient, uint256 _tokenId) external {
+        _mint(_recipient, _tokenId);
+    }
+}

test/0.8.25/vaults/dashboard/contracts/VaultHub__MockForDashboard.sol

@@ -41,19 +41,27 @@ contract VaultHub__MockForDashboard {
         emit Mock__VaultDisconnected(vault);
     }
 
-    function mintSharesBackedByVault(address /* vault */, address recipient, uint256 amount) external {
+    function mintSharesBackedByVault(address vault, address recipient, uint256 amount) external {
         steth.mintExternalShares(recipient, amount);
+        vaultSockets[vault].sharesMinted = uint96(vaultSockets[vault].sharesMinted + amount);
     }
 
-    function burnSharesBackedByVault(address /* vault */, uint256 amount) external {
-        steth.burnExternalShares(amount);
+    function burnSharesBackedByVault(address _vault, uint256 _amountOfShares) external {
+        if (_vault == address(0)) revert ZeroArgument("_vault");
+        if (_amountOfShares == 0) revert ZeroArgument("_amountOfShares");
+        steth.burnExternalShares(_amountOfShares);
+        vaultSockets[_vault].sharesMinted = uint96(vaultSockets[_vault].sharesMinted - _amountOfShares);
     }
 
     function voluntaryDisconnect(address _vault) external {
         emit Mock__VaultDisconnected(_vault);
     }
 
     function rebalance() external payable {
+        vaultSockets[msg.sender].sharesMinted = 0;
+
         emit Mock__Rebalanced(msg.value);
     }
+
+    error ZeroArgument(string argument);
 }