Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: TW deploy script #939

Open
wants to merge 41 commits into
base: feat/withdrawal-credentials
Choose a base branch
from
Open

Feat: TW deploy script #939

wants to merge 41 commits into from
+1,113 −142

Conversation

F4ever
Copy link
Member

@F4ever F4ever commented Feb 10, 2025

Script to deploy contracts fro TW.

  • Withdrawal Vault + library
  • VEBO

eddort and others added 18 commits December 11, 2024 14:28
@eddort
feat: initial deploy to local devnet
483b442
@eddort
feat: speed up scratch deployment for local-devnet
e5aa190
@eddort
refactor: add deployed-local-devnet.json to gitignore
ee55926
@tamtamchik
chore: add default pk for local devnet
ce8c268
@eddort
feat: decrease voting time for devnet
2983d01
@eddort
fix: consensusVersion in VEBO defaults
e879318
@eddort
feat: update default params for devnet
ce1e448
@eddort
feat: custom SLOTS_PER_EPOCH support
e622b3b
@Amuhar
fix: change the module type on curated-onchain-v1 for SimpleDVT in th…
6c8bab8 
…e scratch deploy
@mkurayan
Merge branch 'feat/withdrawal-credentials' into feat/val-1556-move-ve…
7232f9f 
…bo-legacy-tests-WC-lib
@Amuhar
feat: exit request data hash storage, triggerExitHashVerify method, h…
9ca0832 
…appyPath and triggerExitHashVerify tests
@Amuhar
Use of withdrawal vault contract in veb
b0b402c
@Amuhar
fix: tests after changing ReportData
96962ec
@mkurayan
Merge commit '2d11786ebc1f06165c501fa8e9fecef053e12ab9' into feat/loc…
2c5f189 
…al-devnet

# Conflicts:
#	hardhat.config.ts
@eddort
feat: add block explorer verify params to hh config
2488ef7
@eddort
Merge branch 'feat/local-devnet' of github.com:lidofinance/core into …
be1e2d8 
…feat/local-devnet
@Amuhar
Merge branch 'feat/withdrawal-credentials' into feat/val-1456-tw-vebo…
b5d240c 
…-part
@F4ever
feat: add tw deploy script
2e1a0d1
@F4ever F4ever requested review from a team as code owners February 10, 2025 09:19
@F4ever F4ever changed the base branch from master to feat/withdrawal-credentials February 10, 2025 09:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   512       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                316       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               40       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   189-190
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3035     118  96.11%

Diff against master

Filename                               Stmts    Miss  Cover
-----------------------------------  -------  ------  --------
contracts/0.8.9/WithdrawalVault.sol      +19       0  +100.00%
TOTAL                                    +19       0  +0.02%

Results for commit: 7feab5d

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

@F4ever F4ever changed the title Feat: TW deply script Feat: TW deploy script Feb 11, 2025
@tamtamchik
Copy link
Member

Failing tests will be fixed with #942

dav3yblaz3
dav3yblaz3 approved these changes Feb 17, 2025
View reviewed changes
Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good team lets get this to test

dav3yblaz3
dav3yblaz3 approved these changes Feb 17, 2025
View reviewed changes
Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us get this going to test team thank you

Amuhar and others added 18 commits February 17, 2025 12:20
@Amuhar
fix: vebo tw unit tests
46b3c40
@Amuhar
Merge branch 'develop' into feat/val-1456-tw-vebo-part
e8eb1b5
@Amuhar
Merge branch 'feat/withdrawal-credentials' into feat/val-1456-tw-vebo…
30ff891 
…-part
@eddort
fix: hardhat config types
8ffcf2b
@eddort
Revert "feat: speed up scratch deployment for local-devnet"
72a4628 
This reverts commit e5aa190.
@eddort
Merge branch 'develop' of github.com:lidofinance/core into feat/local…
965cd4c 
…-devnet
@eddort
fix: integration tests
6e7c60e
@eddort
fix: IDepositContract format
d1fc7ec
@eddort
refactor: reset defaults
f22a7a9
@F4ever
feat: merge tw vebo
4d78142
@eddort
refactor: env vars
f4d128f
@eddort
refactor: env example
9492d8f
@eddort
Merge branch 'feat/local-devnet' of github.com:lidofinance/core into …
62d8fbc 
…feat/tw-deploy
@eddort
fix: initialize WithdrawalVault
5e7e304
@eddort
fix: hh etherscan config
b403164
@eddort
fix: wv initialize
6089070
@tamtamchik
Merge pull request #896 from lidofinance/feat/local-devnet
25b4eda 
wip: local devnet
@eddort
Merge branch 'develop' of github.com:lidofinance/core into feat/tw-de…
3deea15 
…ploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3yblaz3 dav3yblaz3 dav3yblaz3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@F4ever @tamtamchik @dav3yblaz3 @eddort @Amuhar @mkurayan