-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pulse support to the PennyLane-Braket plugin for the OQC device #15
Open
lillian542
wants to merge
159
commits into
main
Choose a base branch
from
oqc_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add Python 3.11 support
Also made plugin compatible with new return types specification (amazon-braket#153) Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: Korbinian Kottmann <[email protected]> Co-authored-by: David Wierichs <[email protected]> Co-authored-by: Cody Wang <[email protected]>
Co-authored-by: Korbinian Kottmann <[email protected]>
…ane-plugin-python into oqc_main
…lane-plugin-python into oqc_main
…ane-plugin-python into oqc_main
Co-authored-by: Jean-Christophe Jaskula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds access to the OQC device Lucy through PennyLane's pulse programming module.
Where it was simple to do so, the code was kept general for ease of adding additional devices later. However, some refactoring to remove hardcoded assumptions based on the Lucy device will certainly be necessary to add additional pulse-based devices.
ParametrizedEvolution
as an allowed operation for the OQC Lucy device only_translate_operation
for converting a PennyLaneParameterizedEvolution
to a BraketPulseGate
device
kwarg is added to_translate_operation
, which defaults toNone
pulse_settings
attribute (user-facing) that retrieves and displays some of the device specs (resonant frequency, connectivity, anharmonicity) that users might want in PL simulationsOpen questions:
Testing done:
_translate_operation
function for both constant amplitudes and amplitudes with a callable defining a pulse envelopepulse_settings
and the functions to access device framesParametrizedEvolution
operatorsMerge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.