[Enhancement] Improve 'Key Not Found' Error Messages #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamHsu
previously approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Thank you for modifying the exception message, it will help us better identify the missing flag key.
@NoahHsu @tennosuke5245 I think the updated message is quite clear. Do you have any other suggestions?
|
I think the copyright needs to be updated. can @chen-tf help to check that and run the gradle license plugin in your machine |
|
|
NoahHsu
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
The current log message does not indicate which flag key is not set on the UI panel. If we only observe from the application, it is difficult to identify and add the missing flagr toggle.
Changes
When the flagId and variant cannot be found, include the flag key information from the evaluation context in the message to facilitate subsequent corrections.