Discrepancies in Comments #3419
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dmytroheknt <[email protected]>
| @@ -12,7 +12,7 @@ use crate::{ | |||
| test_utils::{add_prefix, get_random_key_values2}, | |||
| }; | |||
|
|
|||
| // We generate about 2000 keys of length 11 with a key of length 10000 | |||
| // We generate about 200 keys of length 10 with a value of length 10000 | |||
There was a problem hiding this comment.
You are correct about the 2000 -> 200.
About the key length, you are wrong:
- The keys generated by
get_random_key_values2are of length 11: There is akey_prefixof length 1 and an additional randomly generated key of length 10. - The
add_prefixis adding a[0]. The length of the keys is thus 12.
So, I think the right PR is to keep the length of length 11 and remove the add_prefix. We only need a prefix [0] not the overkill [0, 0].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a mismatch in the second doc comment: it references
find_keys_by_prefixbut the function is actually named
find_key_values_by_prefix.Also, the top comment mentions generating about 2000 keys of length 11,
whereas the code sets NUM_ENTRIES to 200 and LEN_KEY to 10.