Terminology Consistency Update. #3433
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SITADRITA1 <[email protected]>
Signed-off-by: SITADRITA1 <[email protected]>
Twey
requested changes
Feb 28, 2025
docker/Dockerfile
Outdated
| @@ -2,11 +2,11 @@ | |||
| # | |||
| # - `git_commit` is the hash of the current git commit — used for | |||
| # versioning information inside the binaries. | |||
| # - `build_date` is the date and time of when the docker image was | |||
| # - `build_date` is the date and time when the docker image was | |||
There was a problem hiding this comment.
To be pedantic, this should probably be ‘at which’.
docker/Dockerfile
Outdated
| # built | ||
| # - `binaries` is the path to the directory containing the Linera | ||
| # binaries. Leave unset to build the binaries from scratch. | ||
| # - `target` is a Rust target quadruple. Currently known to be | ||
| # - `target` is a Rust target quadruplet. Currently known to be |
There was a problem hiding this comment.
Both forms exist, but LLVM (and thus Rust) consistently uses the original form. See, for example, cargo build --help:
--target [<TRIPLE>] Build for the target triple
If anything for consistency we might want to refer to it as a triple, though both our supported targets have four components.
Signed-off-by: SITADRITA1 <[email protected]>
Signed-off-by: SITADRITA1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File: docker_image_description.md
Changed: when the docker image was to when the docker image was.
File: target_description.md
Changed: quadruple to quadruplet.
File: crowdfunding_example_application.md
Changed:
Crowd-funding to Crowdfunding.
crowd-funding to crowdfunding.
crowd-funding to crowdfunding.
crowd-funding to crowdfunding.