Add user operation results in execution outcome #3494
Conversation
| .track_block_size_of(&(&txn_outcome.operation_result)) | ||
| .with_execution_context(chain_execution_context)?; | ||
| resource_controller | ||
| .track_executed_block_size_sequence_extension(operation_results.len(), 1) |
There was a problem hiding this comment.
@afck Should we simplify this away? I believe this function was meant for a single vector but now we have many.
There was a problem hiding this comment.
Right, we currently have multiple sequences of the same length, so we could just add a multiplier to track_executed_block_size_sequence_extension. Probably something for a separate PR, though. Also, the new sequence doesn't have the same length, because it's only as long as the operations, not all transactions.
There was a problem hiding this comment.
@afck We should over-approximate this (basically remove it entirely). IIRC it will never go over 5 bytes per vector.
linera-chain/src/data_types.rs
Outdated
|
|
||
| impl<'de> BcsHashable<'de> for OperationResult {} | ||
|
|
||
| doc_scalar!(OperationResult, "The outcome of a single operation."); |
There was a problem hiding this comment.
@afck Should this be bcs_scalar?
|
To update the formats, you may have to run something |
They are already updated |
Co-authored-by: Andreas Fackler <[email protected]> Signed-off-by: usagi32 <[email protected]>
Ok so |
Motivation
resolves #3378
Test Plan
CI
Release Plan