Miscelaneous fixups #348
Merged
Miscelaneous fixups #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usbInitToolType function uses `deriveDeviceTypeFromButtonEvent` as a fallback when it cannot otherwise discover the type of tool being reported in a packet of kernel events. This fallback was intended to be called for each event in the packet by iterating over the `event_ptr` array. The loop is incorrectly implemented, however. Before we get to this point, the value of `event_ptr` would have already been incremented to the end of the list by the deviceTypeFromEvent loop. This means our calls to deriveDeviceTypeFromButtonEvent are accessing data beyond the valid list of events and possibly even beyond the end of the array. To fix this, we can replace the pointer arithmetic in both loops with array index notation instead. Fixes: 3eacea1 ("Attempt to derive the tool type from a known button/key event") Signed-off-by: Jason Gerecke <[email protected]>
High-res events are "expected" from the kernel going forward. We may not support doing anything with them, but we also shouldn't clutter the logs with error messages. Signed-off-by: Jason Gerecke <[email protected]>
Misplaced newline causes logs some logs to get intermingled. Whichever log follows this one becomes part of the same entry. Signed-off-by: Jason Gerecke <[email protected]>
Remove documentation for parameters that are no longer present. Signed-off-by: Jason Gerecke <[email protected]>
Updates documentation for some of the button-like parameters. The man page for xsetwacom now lists all button-like parameters and the help page now describes the 2nd absolute wheel properly. Signed-off-by: Jason Gerecke <[email protected]>
|
Patchset LGTM. Thank you, Jason! |
|
LGTM, I don't see anything that sticks out as a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides fixes for a few things that I had noticed while working on another set of patches.