[ValueTracking] Add CharWidth argument to getConstantStringInfo (NFC) #106541
+96
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 29, 2024
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
7cca421 to
14e8b41
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
e5b70fc to
cdb7292
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
14e8b41 to
61be980
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
cdb7292 to
d27bc30
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
61be980 to
222a3b7
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
d27bc30 to
deca69b
Compare
The method assumes that host chars and target chars have the same width. Add a CharWidth argument so that it can bail out if the requested char width differs from the host char width. Alternatively, the check could be done at call sites, but this is more error-prone. In the future, this method will be replaced with a different one that allows host/target chars to have different widths. The prototype will be the same except that StringRef is replaced with something that is byte width agnostic. Adding CharWidth argument now reduces the future diff.
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
222a3b7 to
26dc400
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
deca69b to
57104d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method assumes that host chars and target chars have the same width.
Add a CharWidth argument so that it can bail out if the requested char
width differs from the host char width.
Alternatively, the check could be done at call sites, but this is more
error-prone.
In the future, this method will be replaced with a different one that
allows host/target chars to have different widths. The prototype will
be the same except that StringRef is replaced with something that is
byte width agnostic. Adding CharWidth argument now reduces the future
diff.