[Github] Add Zlib at build time to CI container #123489
Conversation
This patch adds zlib at build time to the CI container. This is needed to make an lldb test pass that defaults to using the system lld if it is not explicitly enabled in LLVM_ENABLE_PROJECTS. Fixes llvm#123479 (by fixing the proximal cause).
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch adds zlib at build time to the CI container. This is needed to make an lldb test pass that defaults to using the system lld if it is not explicitly enabled in LLVM_ENABLE_PROJECTS. Fixes #123479 (by fixing the proximal cause). Full diff: https://github.com/llvm/llvm-project/pull/123489.diff 1 Files Affected:
diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index 3757e603f8a102..b600d3b72d9547 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -13,7 +13,8 @@ RUN apt-get update && \
ninja-build \
python3 \
git \
- curl
+ curl \
+ zlib1g-dev
RUN curl -O -L https://github.com/llvm/llvm-project/archive/refs/tags/llvmorg-$LLVM_VERSION.tar.gz && tar -xf llvmorg-$LLVM_VERSION.tar.gz
|
This fixes the test. I want to fix the requires in the test too so it actually checks for what it needs, but putting that on the back-burner for now. |
OK, can you file an issue for this so it doesn't get forgotten? |
|
I kept #123479 open to track that. |
This patch adds zlib at build time to the CI container. This is needed to make an lldb test pass that defaults to using the system lld if it is not explicitly enabled in LLVM_ENABLE_PROJECTS.
Fixes #123479 (by fixing the proximal cause).