bot/modules/dispute: convert to TS #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catrya
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Hi @webwarrior-ws In the message that appears when the solver takes on a dispute, the message Status previous to dispute: appears empty.
|
@Catrya should be fixed now. Brought back line of code that I accidentally deleted when porting to TypeScript. |
grunch
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
thanks @webwarrior-ws please sign your commits for future contributions and add a lightning invoice with an amount of 70k with 24 hours of expiration
Convert bot/modules/disputemodule to TypeScript.
Accidentally introduced when converting to TS (`order.previous_dispute_status` not set in `dispute` function).
webwarrior-ws
force-pushed
the
convert-to-ts-final-2
branch
from
2750e7a to
fc1adf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert bot/modules/disputemodule to TypeScript.