-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 style(ui): Adopt directional icons with RTL languages (#261) #262
base: master
Are you sure you want to change the base?
💄 style(ui): Adopt directional icons with RTL languages (#261) #262
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👍 @alirezaImani-f4L3e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
=========================================
+ Coverage 0.00% 1.35% +1.35%
=========================================
Files 330 474 +144
Lines 22325 19402 -2923
Branches 330 494 +164
=========================================
+ Hits 0 263 +263
+ Misses 21995 18860 -3135
+ Partials 330 279 -51 ☔ View full report in Codecov by Sentry. |
I think a better way is to add an internal rtl control in the ActionIcon and Icon Component |
I think it shouldn’t be managed in ActionIcon because it’s dependent on the icon being used, but ActionIcon shouldn’t be aware of the Icon content. |
is there a problem with pr ? if you would not merge it , please fix this problem . |
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
I have added a useDirection hook to provide app direction using Antd direction config .
We will choose Icons direction using useDirection hook .