feat(core): support custom endpoint and addressing style for S3 #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/afraid-otters-crash.md | 📈 +82 Bytes |
| packages/core/src/utils/storage/index.ts | 📈 +36 Bytes |
| packages/core/src/utils/storage/s3-storage.ts | 📈 +796 Bytes |
| packages/schemas/src/types/system.ts | 📈 +44 Bytes |
anyidea
force-pushed
the
master
branch
3 times, most recently
from
9b812c6 to
74b8096
Compare
anyidea
changed the title
|
@wangsijie would you like to take a look on this PR since you are familiar with this, thanks! |
wangsijie
approved these changes
Jan 7, 2025
gao-sun
approved these changes
Jan 7, 2025
|
@anyidea one last step, could you please re-commit and sign with your GPG key? |
anyidea
force-pushed
the
master
branch
5 times, most recently
from
aeaa61f to
ce54b46
Compare
Add support for configurable S3 endpoint and addressing style (path-style/virtual-hosted) to improve compatibility with S3-compatible storage services. - Add forcePathStyle option to control URL addressing style - Fix custom endpoint support implementation - Improve URL generation logic for different configurations Resolves: [logto-io#6920] Signed-off-by: aiden_lu <[email protected]>
|
wangsijie
pushed a commit
that referenced
this pull request
Jan 24, 2025
Add support for configurable S3 endpoint and addressing style (path-style/virtual-hosted) to improve compatibility with S3-compatible storage services. - Add forcePathStyle option to control URL addressing style - Fix custom endpoint support implementation - Improve URL generation logic for different configurations Resolves: [#6920] Signed-off-by: aiden_lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for configurable S3 endpoint and addressing style (path-style/virtual-hosted) to improve compatibility with S3-compatible storage services.
Resolves: [#6920]
Testing
Checklist
.changeset