Training6 task2 #59
Open
Training6 task2 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbui1995
reviewed
Sep 30, 2021
|
|
||
| function* networkSaga() { | ||
| try { | ||
| yield delay(500); |
There was a problem hiding this comment.
@thienvu23 why do we need to use delay here?
There was a problem hiding this comment.
I don't think we need to delay and put action network status here, you can set default navigator.onLine on reducer I commented above
vanbui1995
reviewed
Sep 30, 2021
|
|
||
| function* networkCheckAutoSubmitting() { | ||
| let taskRunSubmittingAuto; | ||
| while (true) { |
There was a problem hiding this comment.
@thienvu23
we don't put network action in the init app anymore, so you need to change code here a bit
vanbui1995
reviewed
Sep 30, 2021
| import { syncNetworkStatus } from "../actions/network"; | ||
|
|
||
| const initialState = { | ||
| isConnected: false, |
There was a problem hiding this comment.
should get from navigator.onLine instead of set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Training 6 task 2 is complete