Skip to content

Commit

Permalink
Adding "Loading..." text to dialogs
Browse files Browse the repository at this point in the history
  • Loading branch information
nathancarter committed Oct 24, 2017
1 parent 7e2d306 commit 4f3f68b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 9 deletions.
9 changes: 2 additions & 7 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ This project was put together rather quickly, and there are many polishing
tasks that should be done to improve the overall quality of this module.
I list them in this file.

## Functionality

* When the file browser, show a "loading..." message until it is
populated.

## Aesthetics

* The open/save dialogs are extremely ugly, because near-zero CSS styling
Expand All @@ -21,8 +16,8 @@ I list them in this file.
* The Open, Save, and Cancel buttons are defined in
[dialog.html](dialog.html), and you can see their element types and
IDs there.
* In that same HTML file you will find the IDs for the files list and
buttons footer.
* In that same HTML file you will find the IDs for the files list, the
buttons footer, and the "Loading..." text.
* Other tidbits appear in the existing [dialog.css](dialog.css) file.
* Consider replacing them entirely with
[jquery.filebrowser](https://github.com/jcubic/jquery.filebrowser)
Expand Down
4 changes: 4 additions & 0 deletions example/example.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
<head>
<!-- Import the cloud storage module. -->
<script src='https://cdn.jsdelivr.net/gh/lurchmath/[email protected]/release/cloud-storage.js'></script>
<!-- Developers testing cloud-storage updates can use this line: -->
<!--
<script src='../release/cloud-storage.js'></script>
-->
<!-- We aim to test the Dropbox backend, so we need its SDK. -->
<script src='https://unpkg.com/dropbox/dist/Dropbox-sdk.min.js'>
</script>
Expand Down
2 changes: 1 addition & 1 deletion release/cloud-storage.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion source/dialog.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</head>
<body>
<!-- The files/folders list is displayed in the following DIV. -->
<div id='filesList'></div>
<div id='filesList'><span id='loading'>Loading...</span></div>
<!--
The following footer appears at the bottom of the dialog, placed
there by CSS styling in dialog.css. Its various elements are not
Expand Down

0 comments on commit 4f3f68b

Please sign in to comment.