Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do not merge until Git dependencies removed] Uncompressed Encodings for Affine Points #192

Closed
wants to merge 2 commits into from
Closed

[Do not merge until Git dependencies removed] Uncompressed Encodings for Affine Points #192

wants to merge 2 commits into from

Conversation

winston-h-zhang
Copy link
Contributor

This PR patches the pasta_curve dependency to the latest on lurk-lab/pasta_curves#2 to allow development/internal use of the UncompressedEncoding API until zcash/pasta_curves#73 is merged.

@winston-h-zhang winston-h-zhang mentioned this pull request Jun 6, 2023
Closed
@huitseeker huitseeker changed the base branch from main to dev June 7, 2023 22:58
huitseeker
huitseeker suggested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately patches are not transitive, so if we were to merge this, any downstream project relying on the present branch would not get the patched pasta, but the vanilla one.

We need to update the dependency straight up.

@huitseeker
Copy link
Contributor

This was made obsolete by #193, which will import lurk-lab/pasta_curves#5 the moment it's merged. Thanks for providing the impetus for this!

@huitseeker huitseeker closed this Jun 12, 2023
@huitseeker huitseeker reopened this Sep 28, 2023
@huitseeker huitseeker force-pushed the dev branch 2 times, most recently from 576049a to bf4a579 Compare October 26, 2023 13:19
@huitseeker huitseeker force-pushed the dev branch 3 times, most recently from e2a4979 to 5ec8d10 Compare October 27, 2023 09:29
@huitseeker huitseeker force-pushed the dev branch 6 times, most recently from 35e7700 to f65b3e9 Compare November 7, 2023 21:14
@huitseeker huitseeker mentioned this pull request Nov 8, 2023
Merged
@huitseeker huitseeker force-pushed the dev branch 2 times, most recently from 0cc7198 to 2221eb0 Compare November 13, 2023 22:30
@huitseeker huitseeker force-pushed the dev branch 2 times, most recently from fb725ed to b692e19 Compare December 23, 2023 21:13
@huitseeker
Copy link
Contributor

Closing due to a change in strategy in lurk-lang/arecibo#332

@huitseeker huitseeker closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker Awaiting requested review from huitseeker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winston-h-zhang @huitseeker