-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unify font icon size in difference style #4058
base: master
Are you sure you want to change the base?
Conversation
Hi @Allsochen, Could you please elaborate on what the problem is with the current values, and how you picked the new ones? Thank you 🙇 |
Ensure that the middle size is consistent with the system in each style, and also ensure that the font size of each style is the same, so that the user experience is more consistent. Also can you explain why the time logs here are inconsistent? |
Hey @Allsochen, Sorry for the delay in responding The default font size on macOS is 13px. That's why the current Thumbnails Style Medium is at 13px. You can see the comparison bellow. Be careful to open the images separately. Here in the table, they are upscaled, so they visually don't match. When you open them separately, you can see the size matches.
What do you think? Thank you |
The logs in red come from macOS internals. They have their own logs, with their own format. We can't control their formatting, unfortunately |
In the case of multi-threaded execution, there will be very subtle differences. In order to clearly see which one is executed and which one is executed later, the default time is |
Hey, |
Hey, What do you think? |
Hey, Indeed, it can be useful. I'll revert the format to the long timestamps. I can always override it to the shorter format locally if needed 👍 What do you think about this message? Thank you |
I agree with you. There are differences between AppIcons mode and Thumbnails mode. What do you think? |
I think this would be covered by #3669. Today we offer fixed sizes. We would need to add an automatic size. When we do that, we can look into how Windows 11 is doing it, for inspiration. |
unify font icon size in difference style