Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify font icon size in difference style #4058

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Allsochen
Copy link
Contributor

unify font icon size in difference style

@lwouis
Copy link
Owner

lwouis commented Jan 4, 2025

Hi @Allsochen,

Could you please elaborate on what the problem is with the current values, and how you picked the new ones?

Thank you 🙇

@Allsochen
Copy link
Contributor Author

Hi @Allsochen,

Could you please elaborate on what the problem is with the current values, and how you picked the new ones?

Thank you 🙇

Ensure that the middle size is consistent with the system in each style, and also ensure that the font size of each style is the same, so that the user experience is more consistent.

Also can you explain why the time logs here are inconsistent?
QQ 2025-01-06 11 10 42

@lwouis
Copy link
Owner

lwouis commented Jan 11, 2025

Hey @Allsochen,

Sorry for the delay in responding

The default font size on macOS is 13px. That's why the current Thumbnails Style Medium is at 13px.
The default AppIcons Style Medium is at 15px to match the native app-switcher
Finally, for the default Titles style, the icons has been made 26 for the Medium to get a more compacted look. The icons decide the height of each row. In Titles mode, users most likely want to have the rows a bit compacted; not too much vertical padding.

You can see the comparison bellow. Be careful to open the images separately. Here in the table, they are upscaled, so they visually don't match. When you open them separately, you can see the size matches.

Style Native AltTab
App Icons image image
Thumbnails image image

What do you think?

Thank you

@lwouis
Copy link
Owner

lwouis commented Jan 12, 2025

Also can you explain why the time logs here are inconsistent?

The logs in red come from macOS internals. They have their own logs, with their own format. We can't control their formatting, unfortunately

@Allsochen
Copy link
Contributor Author

Also can you explain why the time logs here are inconsistent?

The logs in red come from macOS internals. They have their own logs, with their own format. We can't control their formatting, unfortunately

In the case of multi-threaded execution, there will be very subtle differences. In order to clearly see which one is executed and which one is executed later, the default time is 2025-01-06 11:07:10.008. I don’t think we need to modify it to make it shorter.

@lwouis
Copy link
Owner

lwouis commented Jan 14, 2025

Hey,
Regarding the log format, I went with the following logic.
Most of the time, it's useful to have a short format. It's especially useful for the use case of users looking at logs to try and debug an issue. It's also useful locally for developpement, in most case.
You're correct that in some cases, more detailed logs are useful. In those cases, we can increase precision by directly updating the format in the code.
Thank you

@Allsochen
Copy link
Contributor Author

Hey,
Many times we cannot predict when problems will occur during parallel execution, so we don’t think about improving accuracy. Therefore, I recommend using a high-precision time format at all times.

What do you think?

@lwouis
Copy link
Owner

lwouis commented Jan 17, 2025

Hey,

Indeed, it can be useful. I'll revert the format to the long timestamps. I can always override it to the shorter format locally if needed 👍

What do you think about this message?

Thank you

@Allsochen
Copy link
Contributor Author

What do you think about #4058 (comment)?

I agree with you. There are differences between AppIcons mode and Thumbnails mode.
However, there is a problem here. In Thumbnails mode, Windows 11 will automatically adjust the number of thumbnails displayed, but it only reduces the thumbnails, and does not reduce the icons and fonts. However, the font sizes of our small, medium and large fonts will change, so we need a way to meet this demand.

What do you think?

@lwouis
Copy link
Owner

lwouis commented Jan 27, 2025

Windows 11 will automatically adjust the number of thumbnails displayed, but it only reduces the thumbnails

I think this would be covered by #3669. Today we offer fixed sizes. We would need to add an automatic size. When we do that, we can look into how Windows 11 is doing it, for inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants