Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change formatter from yapf to black #5

Merged
merged 1 commit into from
May 5, 2023

Conversation

kitagry
Copy link
Member

@kitagry kitagry commented May 4, 2023

yapf doesn't support python 3.10 syntax. So, I want to change formatter from yapf to black.

@kitagry kitagry requested review from yokomotod and hirosassa May 4, 2023 07:28
Copy link

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think Black is a good choice of formatter, and I also think we should report yapf to follow the Python 3.10 syntax, too.
My recommendation is to report (I mean raise a issue) for this problem to yapf repo.
What do you think?

@kitagry
Copy link
Member Author

kitagry commented May 4, 2023

The issue is already reported. e.x) google/yapf#1045

Copy link
Collaborator

@yokomotod yokomotod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Great first step to switching formatter in the whole.

@hirosassa hirosassa merged commit 3bf7f96 into m3dev:main May 5, 2023
@hirosassa
Copy link

merged! thanks!

@kitagry kitagry deleted the change-formatter branch May 6, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants