Merge pull request #64 from macacajs/test-delegate

test(delegate): test dingtalk integration, pass response to controller

.prettierrc

@@ -0,0 +1,4 @@
+{
+  "trailingComma": "es5",
+  "singleQuote": true
+}

app/controller/delegate.js

@@ -1,28 +1,24 @@
 'use strict';
 
-const {
-  Controller,
-} = require('egg');
+const { Controller } = require('egg');
 
 class DelegateController extends Controller {
-
   async message() {
     const ctx = this.ctx;
-    const {
-      webhook,
-      text,
-      title,
-    } = ctx.request.body;
+    const { webhook, text, title } = ctx.request.body;
 
-    await ctx.helper.sendMarkdown({
+    const res = await ctx.helper.sendMarkdown({
       webhook,
       title: title || 'title',
       text,
     });
 
-    ctx.success({});
+    if (res.data) {
+      ctx.success(res.data);
+    } else {
+      ctx.success({});
+    }
   }
-
 }
 
 module.exports = DelegateController;

app/extend/helper.js

@@ -3,16 +3,20 @@
 const debug = require('debug')('reliable:reliable-dingtalk');
 const ChatBot = require('dingtalk-robot-sender');
 
+// response format is axios
+// https://github.com/axios/axios#response-schema
+// https://github.com/x-cold/dingtalk-robot/blob/master/lib/bot.js
 const sendMarkdown = async options => {
   debug(options);
   const robot = new ChatBot({
     webhook: options.webhook.url,
   });
+  let res;
   if (options.isRawMarkdown) {
-    await robot.markdown(options.title, options.text);
-    return;
+    res = await robot.markdown(options.title, options.text);
   }
-  await robot.markdown(options.title, options.text.join('\n\n'));
+  res = await robot.markdown(options.title, options.text.join('\n\n'));
+  return res;
 };
 
 module.exports = {

config/config.local.js

@@ -1,10 +1,10 @@
 'use strict';
 
 module.exports = () => {
-  const config = exports = {};
+  const config = (exports = {});
 
   config.reliableView = {
-    // assetsUrl: '//127.0.0.1:8080',
+    assetsUrl: '//127.0.0.1:8080',
   };
   config.authorize = {
     enable: false,
@@ -22,4 +22,3 @@ module.exports = () => {
   };
   return config;
 };
-

docker/reliable-web/README.md

@@ -70,6 +70,7 @@ start server:
 
 ```bash
 npm run dev
+# open app at localhost:7001
 ```
 
 insert seed data:

test/app/controller/delegate.test.js

@@ -0,0 +1,40 @@
+'use strict';
+
+const { app, assert } = require('egg-mock/bootstrap');
+
+describe('test/app/controller/delegate.test.js', () => {
+  const webhook = {
+    url: 'https://oapi.dingtalk.com/robot/send?access_token=xxxxx',
+  };
+  const title = 'test title';
+  const text = [ 'text1', 'text2' ];
+  const responseData = { test: 1 };
+
+  before(function() {
+    app.mockContext({
+      helper: {
+        sendMarkdown: async options => {
+          assert.deepStrictEqual(options.webhook, webhook);
+          assert.deepStrictEqual(options.title, title);
+          assert.deepStrictEqual(options.text, text);
+          return {
+            data: responseData,
+          };
+        },
+      },
+    });
+  });
+
+  it('POST /api/delegate/message delegate message', async () => {
+    const { body } = await app
+      .httpRequest()
+      .post('/api/delegate/message')
+      .send({
+        webhook,
+        title,
+        text,
+      });
+    assert(body.success);
+    assert.deepStrictEqual(body.data, responseData);
+  });
+});