Update particles-demo.tsx #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated `theme` prop from useTheme hook to `resolvedTheme` cause of case with system theme. In `theme` prop in that case will be "system" but in `resolvedTheme` var will be "dark" or "light"
|
@qamarq is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
Literally no affect on performance and its fixing bug when u have theme vairbale setted to 'system' (like default). my solution is fixing that and even if u have system colors mode, its giving dark or light. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated
themeprop from useTheme hook toresolvedThemecause of case with system theme. Inthemeprop in that case will be "system" but inresolvedThemevar will be "dark" or "light"