Adding support for Lipizzanerheimat App, Austria #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ila5
reviewed
Jan 8, 2025
| TEST_CASES = { | ||
| # "Köflach - Debug": {"debug": True}, | ||
| "Köflach - Endgasse": {"town": "Köflach", "street": "Endgasse"}, | ||
| "Voitsberg - Bahnweg": {"garbage_calendar_id": 2437, }, |
There was a problem hiding this comment.
Voitsberg - Bahnweg seems to fail
5ila5
reviewed
Jan 8, 2025
|
|
||
| HOW_TO_GET_ARGUMENTS_DESCRIPTION = { # Optional dictionary to describe how to get the arguments, will be shown in the GUI configuration form above the input fields, does not need to be translated in all languages | ||
| "en": "Open the Lipizzanerheimat app, login or use guest mode, select your town, go to the garbage calendar view and select the street you want to get the garbage collection dates for. You can either provide the calendar name in the lower center, the street name and town as written in the dropdown or provide the garbage_calendar_id directly.", | ||
| "de": "Öffnen Sie die Lipizzanerheimat-App, melden Sie sich an oder nutzen Sie den Gastmodus, wählen Sie Ihre Stadt aus, gehen Sie zur Ansicht des Müllkalenders und wählen Sie die Straße aus, für die Sie die Müllabfuhrtermine erhalten möchten. Sie können entweder den Kalendernamen in der unteren Mitte, den Straßennamen und die Stadt, wie sie im Dropdown-Menü geschrieben sind, oder direkt die garbage_calendar_id angeben.", "it": "COME OTTENERE GLI ARGOMENTI", |
There was a problem hiding this comment.
remove "it": "COME OTTENERE GLI ARGOMENTI",
5ila5
reviewed
Jan 8, 2025
Comment on lines
+230
to
+231
| def sha1(self, input_str): | ||
| return hashlib.sha1(input_str.encode('utf-8')).hexdigest() |
There was a problem hiding this comment.
Redefinition can be removed
5ila5
reviewed
Jan 8, 2025
|
|
||
| def _first_setup(self): | ||
|
|
||
| r = requests.get(API_URL) |
There was a problem hiding this comment.
Why this request? r is never accessed, and you don't use a session so this does just nothing but an unnecessary web request
5ila5
reviewed
Jan 8, 2025
| def __init__(self, garbage_calendar_id: int | None = None, street: str | None = None, town: str | None = None, map_name: str | None = None): | ||
|
|
||
| self.items = [] | ||
| self.icons = [] |
There was a problem hiding this comment.
icons should be a dict not a list
5ila5
reviewed
Jan 8, 2025
Comment on lines
+261
to
+262
| return next((c['garbage_calendar_id'] | ||
| for c in calendarData['garbage_calendars'] if c['garbage_calendar_title'] == self.map_name), None) |
There was a problem hiding this comment.
Wouldn't it be better to raise an Exception instead of returning None? You could even provide alternative map_names when raising SourceArgumentNotFoundWithSuggestions
5ila5
reviewed
Jan 8, 2025
Comment on lines
+281
to
+282
| return next((c['garbage_calendars_available'][0] | ||
| for c in calendarData['street_structure'] if c['garbage_calendar_street'] == self.street), None) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Lipizzanerheimat, Austria
Format documentation
reformatting + ./update_docu_links.py
Uses guest credentials that were provided in the code.