Added improvements to reduce errors and such

[CamoCatX]

I added 4 different changes to this script.

1. On powershell 5.1 (comes with default installation of windows), there is a significant time-burner for Invoke-Webrequest and other commands. It comes from writing that light blue progress bar at the top of the window. More info here: Progress bar can significantly impact cmdlet performance PowerShell/PowerShell#2138
2. My next improvement is handling if a user accidently clicks on PowerShell x86. The script then corrects this human error.
3. Disable Keep alive for invoke web request is just because we should not assume that user will have further interaction beyond what is required on the script, so we should remove for potential less latency.
4. I added Microsoft.com instead of Google because of how likely of each to be blocked. This is also for personal privacy reasons, this features adds nothing extra but on a windows machine is usually preferred. I chose not to do a more privacy respecting website because that might also be blocked in a weird corporate environment.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[Ana06]

Thanks for the PR @CamoCatX, nice improvements! ✨

Can you remove the google.com replacement so that we can merge this PR? 😄

[nitpick] I would appreciate a more descriptive commit message, suggestion:

[installer] Improve install.ps1 code

- Remove progress bar for better performance
- Check for PowerShell x86 as it is unsupported
- Disable `KeepAlive` in connectivity check as no subsequent request are
  expected

[Ana06]

Removing the progress bar is a nice improvement! ✨

[Ana06]

As powershell x86 is not working at the moment, I think adding this code is a good idea. But on the long-term, is there a reason why we would want to support powershell x86 (we would need to find alternative implementations for the used function(s))? 🤔 @mandiant/vms opinions?

[Ana06]

Nice improvement, this function is only used to test the internet connection so we do not need a persistent connection to the server as there are not subsequent requests. 👍

[CamoCatX]

@Ana06 I have changed this back to google, even though I personally know many people who would prefer Microsoft if in a windows environment. But it should be able to be merged now.

[CamoCatX]

If I have free time in the future I can look into making this script compatible with pwsh x86. The problem I found when using x86 was with the Set-LocalUser cmdlet. Microsoft documentation lists this: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.localaccounts/set-localuser To resolve this issue we would have to find an alternative to the Microsoft.PowerShell.LocalAccounts module

[Ana06]

Thanks for the modification, but I think you accidentally changed the wrong domain. Please restore the domains in the internet connectivity check so that we can merge the PR.

I would prefer if you could squash your commits (to avoid fix commits in order to keep a clean commit history), but we can also merge the PR with squash an merge if you prefer.

[Ana06]

Thanks for the improvements @CamoCatX!

If I have free time in the future I can look into making this script compatible with pwsh x86. The problem I found when using x86 was with the Set-LocalUser cmdlet. Microsoft documentation lists this: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.localaccounts/set-localuser To resolve this issue we would have to find an alternative to the Microsoft.PowerShell.LocalAccounts module

I have created #615 for this. It would be great if could work on it! 😄 If/When you have time to work on it, just write a comment in the issue to avoid someone else works on it at the same time. 😉