Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag with both attr and value #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Crazyokd
Copy link
Collaborator

@Crazyokd Crazyokd commented Sep 26, 2024

implement #101

@materazu
Copy link

Can we merge that please, needed

@Crazyokd
Copy link
Collaborator Author

@materazu you can try my custom version.

@materazu
Copy link

materazu commented Jan 17, 2025

Thx a lot @Crazyokd, but on our company projet, we can only install via luarocks install standard command.
I worked around the issue by only using attributes with specific naming for the value, and with rebuild regex after text output, it works, it's clearly not clean but it works.

@Crazyokd
Copy link
Collaborator Author

Thx a lot @Crazyokd, but on our company projet, we can only install via luarocks install standard command. I worked around the issue by only using attributes with specific naming for the value, and with rebuild regex after text output, it works, it's clearly not clean but it works.

OK, I'll consider add support for luarocks as soon as possible.

@Crazyokd
Copy link
Collaborator Author

@materazu Now you can use my custom version by using luarocks. I hope you can really try it.

@manoelcampos
Copy link
Owner

manoelcampos commented Jan 20, 2025

@Crazyokd I’m looking for someone to maintain the project. If you are interested, I can even give you the ownership of the repo

@Crazyokd
Copy link
Collaborator Author

@Crazyokd I’m looking for someone to maintain the project. If you are interested, I can even give you the ownership of the repo

@manoelcampos I'm interested in it, but I might make a big design change.

@manoelcampos
Copy link
Owner

manoelcampos commented Jan 21, 2025

Feel free to change as you wish. I'm sending you an invite to join.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants