Add eslint rule named stylistic/semi (#5273)

* Add eslint rule named `stylistic/semi`

* remove unnecessary eslintrc(json)

build/generate-docs.ts

@@ -9,7 +9,7 @@ type HtmlDoc = {
     title: string;
     description: string;
     mdFileName: string;
-}
+};
 
 function generateAPIIntroMarkdown(lines: string[]): string {
     let intro = `# Intro

eslint.config.js

@@ -1,5 +1,5 @@
 import typescriptEslint from '@typescript-eslint/eslint-plugin';
-import stylisticTs from '@stylistic/eslint-plugin-ts'
+import stylisticTs from '@stylistic/eslint-plugin-ts';
 import tsdoc from 'eslint-plugin-tsdoc';
 import vitest from 'eslint-plugin-vitest';
 import globals from 'globals';
@@ -96,6 +96,7 @@ export default [
             'no-useless-escape': 'off',
             indent: 'off',
             '@stylistic/indent': ['error'],
+            '@stylistic/semi': ['error'],
 
             'no-multiple-empty-lines': ['error', {
                 max: 1,

src/data/bucket/fill_extrusion_bucket.ts

@@ -56,7 +56,7 @@ type CentroidAccumulator = {
     x: number;
     y: number;
     sampleCount: number;
-}
+};
 
 export class FillExtrusionBucket implements Bucket {
     index: number;

src/data/dem_data.ts

@@ -6,7 +6,7 @@ import {register} from '../util/web_worker_transfer';
 /**
  * The possible DEM encoding types
  */
-export type DEMEncoding = 'mapbox' | 'terrarium' | 'custom'
+export type DEMEncoding = 'mapbox' | 'terrarium' | 'custom';
 
 /**
  * DEMData is a data structure for decoding, backfilling, and storing elevation data for processing in the hillshade shaders

src/geo/projection/camera_helper.ts

@@ -16,7 +16,7 @@ export type MapControlsDeltas = {
     pitchDelta: number;
     rollDelta: number;
     around: Point;
-}
+};
 
 export type CameraForBoxAndBearingHandlerResult = {
     center: LngLat;
@@ -35,13 +35,13 @@ export type EaseToHandlerOptions = {
     center?: LngLatLike;
     zoom?: number;
     offset?: PointLike;
-}
+};
 
 export type EaseToHandlerResult = {
     easeFunc: (k: number) => void;
     elevationCenter: LngLat;
     isZooming: boolean;
-}
+};
 
 export type FlyToHandlerOptions = {
     bearing: number;
@@ -53,15 +53,15 @@ export type FlyToHandlerOptions = {
     locationAtOffset: LngLat;
     zoom?: number;
     minZoom?: number;
-}
+};
 
 export type FlyToHandlerResult = {
     easeFunc: (k: number, scale: number, centerFactor: number, pointAtOffset: Point) => void;
     scaleOfZoom: number;
     scaleOfMinZoom?: number;
     targetCenter: LngLat;
     pixelPathLength: number;
-}
+};
 
 export type UpdateRotationArgs = {
     /**
@@ -88,7 +88,7 @@ export type UpdateRotationArgs = {
      * If true, use spherical linear interpolation. If false, use linear interpolation of Euler angles.
      */
     useSlerp: boolean;
-}
+};
 
 /**
  * @internal

src/geo/projection/globe_projection.ts

@@ -13,11 +13,11 @@ import {type Mesh} from '../../render/mesh';
 
 type ProjectionProps = {
     type: DataConstantProperty<ProjectionDefinition>;
-}
+};
 
 type ProjectionPossiblyEvaluated = {
     type: ProjectionDefinitionSpecification;
-}
+};
 
 const properties: Properties<ProjectionProps> = new Properties({
     'type': new DataConstantProperty(styleSpec.projection.type as StylePropertySpecification)

src/geo/projection/globe_transform.ts

@@ -270,9 +270,9 @@ export class GlobeTransform implements ITransform {
         this._verticalPerspectiveTransform.apply(this, this._globeLatitudeErrorCorrectionRadians);
     }
 
-    public get projectionMatrix(): mat4 { return this.currentTransform.projectionMatrix }
+    public get projectionMatrix(): mat4 { return this.currentTransform.projectionMatrix; }
 
-    public get modelViewProjectionMatrix(): mat4 { return this.currentTransform.modelViewProjectionMatrix }
+    public get modelViewProjectionMatrix(): mat4 { return this.currentTransform.modelViewProjectionMatrix; }
 
     public get inverseProjectionMatrix(): mat4 { return this.currentTransform.inverseProjectionMatrix; }
 

src/geo/projection/mercator_covering_tiles_details_provider.ts

@@ -42,7 +42,7 @@ export class MercatorCoveringTilesDetailsProvider implements CoveringTilesDetail
     allowVariableZoom(transform: IReadonlyTransform, options: CoveringTilesOptions): boolean {
         const zfov = transform.fov * (Math.abs(Math.cos(transform.rollInRadians)) * transform.height + Math.abs(Math.sin(transform.rollInRadians)) * transform.width) / transform.height;
         const maxConstantZoomPitch = clamp(78.5 - zfov / 2, 0.0, 60.0);
-        return (!!options.terrain || transform.pitch > maxConstantZoomPitch || transform.padding.top >= 0.1)
+        return (!!options.terrain || transform.pitch > maxConstantZoomPitch || transform.padding.top >= 0.1);
     }
 
     allowWorldCopies(): boolean {

src/geo/projection/mercator_transform.ts

@@ -416,7 +416,7 @@ export class MercatorTransform implements ITransform {
         const matrices = {
             f64: tileMatrix,
             f32: new Float32Array(tileMatrix), // Must have a 32 bit float version for WebGL, otherwise WebGL calls in Chrome get very slow.
-        }
+        };
         cache.set(posMatrixKey, matrices);
         // Make sure to return the correct precision
         return useFloat32 ? matrices.f32 : matrices.f64;

src/geo/projection/projection_data.ts

@@ -44,7 +44,7 @@ export type ProjectionData = {
      * Uniform name: `u_projection_fallback_matrix`.
      */
     fallbackMatrix: mat4;
-}
+};
 
 /**
  * Parameters object for the transform's `getProjectionData` function.
@@ -67,4 +67,4 @@ export type ProjectionDataParams = {
      * Set to true if the globe matrix should be applied (i.e. when rendering globe)
      */
     applyGlobeMatrix?: boolean;
-}
+};

src/geo/projection/vertical_perspective_transform.ts

@@ -300,7 +300,7 @@ export class VerticalPerspectiveTransform implements ITransform {
             clippingPlane: this._cachedClippingPlane as [number, number, number, number],
             projectionTransition: applyGlobeMatrix ? 1 : 0,
             fallbackMatrix: this._globeViewProjMatrix32f,
-        }
+        };
     }
 
     private _computeClippingPlane(globeRadiusPixels: number): vec4 {

src/render/line_atlas.ts

@@ -9,7 +9,7 @@ type DashEntry = {
     y: number;
     height: number;
     width: number;
-}
+};
 
 /**
  * @internal

src/render/painter.ts

@@ -75,7 +75,7 @@ type PainterOptions = {
 export type RenderOptions = {
     isRenderingToTexture: boolean;
     isRenderingGlobe: boolean;
-}
+};
 
 /**
  * @internal

src/render/terrain.ts

@@ -35,7 +35,7 @@ export type TerrainData = {
     texture: WebGLTexture;
     depthTexture: WebGLTexture;
     tile: Tile;
-}
+};
 
 /**
  * @internal

src/source/geojson_source.ts

@@ -23,7 +23,7 @@ export type GeoJSONSourceOptions = GeoJSONSourceSpecification & {
     workerOptions?: GeoJSONWorkerOptions;
     collectResourceTiming?: boolean;
     data: GeoJSON.GeoJSON | string;
-}
+};
 
 export type GeoJSONSourceInternalOptions = {
     data?: GeoJSON.GeoJSON | string | undefined;
@@ -32,7 +32,7 @@ export type GeoJSONSourceInternalOptions = {
     clusterRadius?: number;
     clusterMinPoints?: number;
     generateId?: boolean;
-}
+};
 
 /**
  * The cluster options to set
@@ -50,7 +50,7 @@ export type SetClusterOptions = {
      * The cluster's radius
      */
     clusterRadius?: number;
-}
+};
 
 /**
  * A source containing GeoJSON.

src/source/geojson_source_diff.ts

@@ -23,7 +23,7 @@ export type GeoJSONSourceDiff = {
      * An array of update objects
      */
     update?: Array<GeoJSONFeatureDiff>;
-}
+};
 
 /**
  * A geojson feature diff object
@@ -49,7 +49,7 @@ export type GeoJSONFeatureDiff = {
      * The properties to add or update along side their values
      */
     addOrUpdateProperties?: Array<{key: string; value: any}>;
-}
+};
 
 export type UpdateableGeoJSON = GeoJSON.Feature | GeoJSON.FeatureCollection | undefined;
 

src/source/geojson_worker_source.ts

@@ -31,7 +31,7 @@ export type GeoJSONWorkerOptions = {
     filter?: Array<unknown>;
     promoteId?: string;
     collectResourceTiming?: boolean;
-}
+};
 
 /**
  * Parameters needed to load a geojson to the worker

src/source/image_source.ts

@@ -36,7 +36,7 @@ export type UpdateImageOptions = {
      * The image coordinates
      */
     coordinates?: Coordinates;
-}
+};
 
 /**
  * A data source containing an image.

src/source/load_tilejson.ts

@@ -16,7 +16,7 @@ export type LoadTileJsonResponse = {
     tileSize: number;
     encoding: RasterDEMSourceSpecification['encoding'];
     vectorLayerIds?: Array<string>;
-}
+};
 
 export async function loadTileJson(
     options: RasterSourceSpecification | RasterDEMSourceSpecification | VectorSourceSpecification,

src/source/query_features.ts

@@ -33,7 +33,7 @@ export type QueryRenderedFeaturesOptions = {
 
 export type QueryRenderedFeaturesOptionsStrict = Omit<QueryRenderedFeaturesOptions, 'layers'> & {
     layers: Set<string> | null;
-}
+};
 
 /**
  * The options object related to the {@link Map#querySourceFeatures} method
@@ -53,7 +53,7 @@ export type QuerySourceFeatureOptions = {
      * @defaultValue true
      */
     validate?: boolean;
-}
+};
 
 /*
  * Returns a matrix that can be used to convert from tile coordinates to viewport pixel coordinates.

src/source/source.ts

@@ -128,7 +128,7 @@ export interface Source {
  */
 export type SourceClass = {
     new (id: string, specification: SourceSpecification | CanvasSourceSpecification, dispatcher: Dispatcher, eventedParent: Evented): Source;
-}
+};
 
 /**
  * Creates a tiled data source instance given an options object.

src/source/source_cache.ts

@@ -31,7 +31,7 @@ type TileResult = {
     queryGeometry: Array<Point>;
     cameraQueryGeometry: Array<Point>;
     scale: number;
-}
+};
 
 /**
  * @internal

src/source/vector_tile_source.ts

@@ -17,7 +17,7 @@ import {MessageType} from '../util/actor_messages';
 export type VectorTileSourceOptions = VectorSourceSpecification & {
     collectResourceTiming?: boolean;
     tileSize?: number;
-}
+};
 
 /**
  * A source containing vector tiles in [Mapbox Vector Tile format](https://docs.mapbox.com/vector-tiles/reference/).

src/source/vector_tile_worker_source.ts

@@ -27,7 +27,7 @@ type FetchingState = {
     rawTileData: ArrayBuffer;
     cacheControl: ExpiryData;
     resourceTiming: any;
-}
+};
 
 export type AbortVectorData = () => void;
 export type LoadVectorData = (params: WorkerTileParameters, abortController: AbortController) => Promise<LoadVectorTileResult | null>;

src/style/load_sprite.ts

@@ -13,7 +13,7 @@ export type LoadSpriteResult = {
     [spriteName: string]: {
         [id: string]: StyleImage;
     };
-}
+};
 
 export function normalizeSpriteURL(url: string, format: string, extension: string): string {
     try {
@@ -22,7 +22,7 @@ export function normalizeSpriteURL(url: string, format: string, extension: strin
         return parsed.toString();
     }
     catch {
-        throw new Error(`Invalid sprite URL "${url}", must be absolute. Modify style specification directly or use TransformStyleFunction to correct the issue dynamically`)
+        throw new Error(`Invalid sprite URL "${url}", must be absolute. Modify style specification directly or use TransformStyleFunction to correct the issue dynamically`);
     }
 }
 

src/style/style.ts

@@ -184,7 +184,7 @@ export type StyleSwapOptions = {
      * that allows to modify a style after it is fetched but before it is committed to the map state. Refer to {@link TransformStyleFunction}.
      */
     transformStyle?: TransformStyleFunction;
-}
+};
 
 /**
  * Specifies a layer to be added to a {@link Style}. In addition to a standard {@link LayerSpecification}

src/style/style_image.ts

@@ -7,7 +7,7 @@ export type SpriteJSON = {[id: string]: StyleImageMetadata & {
     height: number;
     x: number;
     y: number;
-};}
+};};
 
 /**
  * The sprite data

src/style/style_layer/custom_style_layer.ts

@@ -105,7 +105,7 @@ export type CustomRenderMethodInput = {
      * or more accurately for globe, elevation above the surface of the perfect sphere used to render the planet.
      */
     defaultProjectionData: ProjectionData;
-}
+};
 
 /**
  * @param gl - The map's gl context.

src/symbol/grid_index.ts

@@ -31,7 +31,7 @@ type QueryResult<T> = {
  */
 export type GridKey = {
     overlapMode?: OverlapMode;
-}
+};
 
 function overlapAllowed(overlapA: OverlapMode, overlapB: OverlapMode): boolean {
     let allowed = true;

src/symbol/projection.ts

@@ -399,7 +399,7 @@ function requiresOrientationChange(writingMode, firstPoint, lastPoint, aspectRat
 
 type GlyphLinePlacementResult = OrientationChangeType & {
     notEnoughRoom?: boolean;
-}
+};
 
 type GlyphLinePlacementArgs = {
     projectionContext: SymbolProjectionContext;
@@ -412,7 +412,7 @@ type GlyphLinePlacementArgs = {
     dynamicLayoutVertexArray: StructArray;
     aspectRatio: number;
     rotateToLine: boolean;
-}
+};
 
 /*
 * Place first and last glyph along the line projected to label plane, and if they fit