-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few minor accessibility issues with examples #4205
Fix a few minor accessibility issues with examples #4205
Conversation
- Link labels to inputs - Add missing title and viewport to GL Stats page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gl stats is internal for testing, but I don't mind having it improved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4205 +/- ##
==========================================
+ Coverage 87.52% 87.69% +0.17%
==========================================
Files 242 242
Lines 33080 33080
Branches 2178 2159 -19
==========================================
+ Hits 28952 29009 +57
+ Misses 3131 3085 -46
+ Partials 997 986 -11 ☔ View full report in Codecov by Sentry. |
I was going to suggest adding a HTMLHint test to make sure there are no bugs with all the HTML pages in the repo. For now you can run:
for a {
"alt-require": true,
"attr-lowercase": true,
"attr-no-duplication": true,
"attr-unsafe-chars": true,
"attr-value-double-quotes": false,
"attr-value-not-empty": false,
"doctype-first": false,
"doctype-html5": true,
"head-script-disabled": false,
"href-abs-or-rel": false,
"html-lang-require": true,
"id-class-ad-disabled": true,
"id-class-value": false,
"id-unique": true,
"inline-script-disabled": false,
"inline-style-disabled": false,
"spec-char-escape": false,
"src-not-empty": true,
"style-disabled": false,
"tag-pair": false,
"tag-self-close": false,
"tagname-lowercase": true,
"title-require": true
} |
But we have eslint with the html plugin already running... Are there rules there we can add? |
I'll take a look! |
@HarelM - re: eslint with the html plugin already running https://www.npmjs.com/package/eslint-plugin-html
So maybe need to add this too: https://html-eslint.org/ |
Feel free to add this. although, all these plugins are a hazard when eslint is releasing a breaking change version like they did with 9.0, as these tend to not be maintained, as start to fail. |
Launch Checklist
CHANGELOG.md
under the## main
section.