convert names in links to be URI encoded (#2229)

maproulette · Jan 8, 2024 · 50a02ab · 50a02ab
1 parent 0ab7543
commit 50a02ab
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/components/ChallengeDetail/FlagCommentInput.js b/src/components/ChallengeDetail/FlagCommentInput.js
@@ -27,7 +27,7 @@ export class FlagCommentInput extends Component {
       const challenge = this.props.challenge
       const owner = process.env.REACT_APP_GITHUB_ISSUES_API_OWNER
       const repo = process.env.REACT_APP_GITHUB_ISSUES_API_REPO
-      const body = `Challenge: [#${challenge.id} - ${challenge.name}](${process.env.REACT_APP_URL}/browse/challenges/${challenge.id}) \n\n Reported by: [${this.props.user.osmProfile.displayName}](https://www.openstreetmap.org/user/${this.props.user.osmProfile.displayName})\n\n${this.state.value}`
+      const body = `Challenge: [#${challenge.id} - ${challenge.name}](${process.env.REACT_APP_URL}/browse/challenges/${challenge.id}) \n\n Reported by: [${this.props.user.osmProfile.displayName}](https://www.openstreetmap.org/user/${encodeURIComponent(this.props.user.osmProfile.displayName)})\n\n${this.state.value}`
       const response = await fetch(`https://api.github.com/repos/${owner}/${repo}/issues`, {
         method: 'POST',
         body: JSON.stringify({

diff --git a/src/pages/Leaderboard/CardLeaderboard.js b/src/pages/Leaderboard/CardLeaderboard.js
@@ -44,7 +44,7 @@ class CardLeaderboard extends Component {
       >
         <header className={"mr-max-w-xs mr-mx-auto mr-mb-2 " + (this.state.isHover ? 'hover-style': '')}>
           <a
-            href={'https://www.openstreetmap.org/user/' + leader.name} target="_blank" rel="noreferrer"
+            href={'https://www.openstreetmap.org/user/' + encodeURIComponent(leader.name)} target="_blank" rel="noreferrer"
             className="mr-block mr-w-24 mr-h-24 mr-bg-black mr-bg-cover mr-bg-center mr-mx-auto mr-mb-4 mr-rounded-full hover-pic"
             style={{ backgroundImage: `url(${AsAvatarUser(leader).profilePic(256)})` }}
             onMouseOver={this.onHover}
@@ -55,7 +55,7 @@ class CardLeaderboard extends Component {
               <FormattedNumber value={leader.rank} />
             </span>
             <a 
-              href={'https://www.openstreetmap.org/user/' + leader.name} target="_blank" rel="noreferrer" 
+              href={'https://www.openstreetmap.org/user/' + encodeURIComponent(leader.name)} target="_blank" rel="noreferrer" 
               className="mr-text-white card-name hover-name"
               onMouseOver={this.onHover}
               onMouseLeave={this.onLeave}

diff --git a/src/pages/Leaderboard/RowLeaderboard.js b/src/pages/Leaderboard/RowLeaderboard.js
@@ -46,15 +46,15 @@ class RowLeaderboard extends Component {
             </div>
             <div className={"md:mr-flex mr-items-center " + (this.state.isHover ? 'hover-style': '')}>
               <a
-                href={'https://www.openstreetmap.org/user/' + leader.name} target="_blank" rel="noreferrer"
+                href={'https://www.openstreetmap.org/user/' + encodeURIComponent(leader.name)} target="_blank" rel="noreferrer"
                 className="mr-block mr-w-20 mr-h-20 mr-bg-black mr-bg-cover mr-bg-center mr-mx-auto mr-rounded-full hover-pic"
                 style={{ backgroundImage: `url(${AsAvatarUser(leader).profilePic(256)})` }}
                 onMouseOver={this.onHover}
                 onMouseLeave={this.onLeave}
               />
               <div className="md:mr-pl-8">
                 <a 
-                  href={'https://www.openstreetmap.org/user/' + leader.name} target="_blank" rel="noreferrer"
+                  href={'https://www.openstreetmap.org/user/' + encodeURIComponent(leader.name)} target="_blank" rel="noreferrer"
                   className="mr-text-lg mr-font-normal mr-mb-2 mr-text-white hover-name"
                   onMouseOver={this.onHover}
                   onMouseLeave={this.onLeave}