Skip to content

Commit

Permalink
revert changes unrelated to this pr
Browse files Browse the repository at this point in the history
  • Loading branch information
CollinBeczak committed Feb 1, 2025
1 parent f44d442 commit ff31df8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ will not be able to make sense of it.
disableOsmIdProperty: {
id: "Admin.EditChallenge.form.disableOsmIdProperty",
defaultMessage:
"This ID cannot be edited after a challenge has successfuly created tasks, this is to prevent task duplication. [Learn more](https://learn.maproulette.org/documentation/setting-external-task-identifiers/).",
"This ID cannot be edited after challenge creation, this is to prevent task duplication. [Learn more](https://learn.maproulette.org/documentation/setting-external-task-identifiers/).",
},

customTaskStyleLabel: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const jsSchema = (intl, user, challengeData) => {
* > proper markup
*/
export const uiSchema = (intl, user, challengeData, extraErrors, options = {}) => {
const sourceReadOnly = !AsEditableChallenge(challengeData).hasZeroTasks();
const sourceReadOnly = !AsEditableChallenge(challengeData);

Check warning on line 57 in src/components/AdminPane/Manage/ManageChallenges/EditChallenge/Schemas/PropertiesSchema.js

View check run for this annotation

Codecov / codecov/patch

src/components/AdminPane/Manage/ManageChallenges/EditChallenge/Schemas/PropertiesSchema.js#L57

Added line #L57 was not covered by tests
const isCollapsed = options.longForm && (options.collapsedGroups || []).indexOf(STEP_ID) === -1;
const toggleCollapsed =
options.longForm && options.toggleCollapsed
Expand Down
2 changes: 1 addition & 1 deletion src/services/Challenge/Challenge.js
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ export const saveChallenge = function (originalChallengeData, storeResponse = tr
dispatch(receiveChallenges(normalizedResults.entities));
}

return normalizedResults?.entities?.challenges?.[normalizedResults.result];
return _get(normalizedResults, `entities.challenges.${normalizedResults.result}`);
})
.catch((serverError) => {
if (isSecurityError(serverError)) {
Expand Down

0 comments on commit ff31df8

Please sign in to comment.