fix setState error in challenge editor #2226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2226 +/- ##
==========================================
- Coverage 23.72% 23.71% -0.01%
==========================================
Files 648 648
Lines 22344 22347 +3
Branches 6896 6896
==========================================
Hits 5300 5300
- Misses 14253 14256 +3
Partials 2791 2791 ☔ View full report in Codecov by Sentry. |
jschwarz2030
reviewed
Jan 9, 2024
| } catch (error) { | ||
| console.error("Error fetching project managers:", error) | ||
| this.setState({ loadingManagers: false }) | ||
| } |
There was a problem hiding this comment.
this logicially doesn't solve anything and using async in a lifecycle method is an antipattern
There was a problem hiding this comment.
Im not even seeing the error anymore with the previous code, so ill just remove this pr for now and come up with a better solution if the error happens again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes setState error in the challenge create/edit form.