Remove more common lodash patterns that have native JavaScript equivalents #2517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on the theme from #2515, this PR replaces a few more common lodash-isms in the codebase with native JavaScript equivalents.
_first(arr)
and_last(arr)
becomearr[0]
andarr[arr.length - 1]
_indexOf(arr, elem)
becomesarr.indexOf(elem)
_isFinite(val)
becomesNumber.isFinite(val)
_isBoolean(val)
becomestypeof val === "boolean"
_isFunction(val)
becomestypeof val === "function"
(or in cases where it was being used to check if an optional function was present before calling it, I've replaced it with the optional-chaining operatorval?.()
)_isUndefined(val)
becomesval === undefined
_isArray(val)
becomesArray.isArray(val)
Each type of change was made in a separate commit, so you can review them one by one if you prefer.