disable completion buttons #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr resolves: #2538
partially resolves: #2546
What has changed:
Before, users could click on the completion buttons multiple times if they had slow network speed, and in the issue described above, there are some states in the completion process where the user is able to see the completed task version of the completion widget and interact with it, leading to a lot of confusion.
Now, when a user submits a task, the buttons will be greyed out and unclickable, and the completion flow is now async, so the task wont be marked as completed in the ui until the completion endpoint returns and the next task is found.