Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix process hanging when there is too much logging #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmjpmj
Copy link

@pmjpmj pmjpmj commented Nov 30, 2016

No description provided.

@aleofreddi
Copy link

Would be great to have this one merged in

@hmil
Copy link

hmil commented Jul 29, 2020

I believe you can just use reader.close() instead of manually consuming the output in a thread.
@samsieber's fix in #31 is better IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants