[DNM] MCOL-5133: Stage3 stand alone cli tool. #3397
+303
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[add] cluster api client class [fix] cli cluster_app using cluster api client [add] ClusterAction Enum [add] toggle_cluster_state function to reduce code duplication
[fix] client class methods [fix] Transaction management at endpoint handling level [fix] add_node and set_mode methods to use TransactionManager
MAJOR: Some logic inside node remove changed significantly using active
nodes list from Columnstore.xml to broadcast config after remove.
[fix] remove node logic to use Transaction manager
[fix] cluster set api key call using totp on a top level cli call
[add] missed docstrings
mariadb-AlanMologorsky
changed the title
drrtuy
reviewed
Feb 9, 2025
| raise CMAPIBasicError('Error while removing node.') from err | ||
|
|
||
| response['node_id'] = node | ||
| if len(txn_nodes) > 0: | ||
| active_nodes = get_active_nodes(config) |
There was a problem hiding this comment.
Could you elaborate on the reasons for this change @mariadb-AlanMologorsky ?
There was a problem hiding this comment.
- Now TransactionManager class used and this value is out of inner function scope.
- While I investigate how to make it visible I made a valuable conclusion that all the time it was wrong logic:
Checking number of nodes which had successful start of transaction after removing one of them is invalid by default. At least there are corner case with removing last one node. I used active nodes from updated MCS configuration instead.
drrtuy
reviewed
Feb 9, 2025
| ) | ||
| response.raise_for_status() | ||
| return response.json() | ||
| # TODO: different handler for timeout exception? |
There was a problem hiding this comment.
Good idea.
Could you point me where do we release the lock if something went south during execution of a command on a cluster ?
There was a problem hiding this comment.
Api client itself just calling remote endpoint, thansaction mechanics never used here. Otherwise it's used on a top level. For eg. here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAJOR: Some logic inside node remove changed significantly using active
nodes list from Columnstore.xml to broadcast config after remove.