Migration for Boost 1.85 #3407
Open
Migration for Boost 1.85 #3407
+12
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boost 1.85 removed some deprecated code in filesystem module which is still used in columnstore: - The boost/filesystem/convenience.hpp was removed but columnstore does not use any functionality from that file except indirect includes. Therefore this include is removed or replaced with more general boost/filesystem.hpp. The convenience.hpp header file was deprecated in filesystem V3 introduced in Boost 1.46.0. - `normalize` method was removed and users are suggested to replace it with `lexically_normal` method, which was introduced in Boost 1.60.0. - The `copy_option` was removed in favor of `copy_options` (note the trailing 's'), but enum values were renamed. Namely, `fail_if_exists` is replaced with `none` and `overwrite_if_exists` is replaced with `overwrite_existing`. The `copy_options` was introduced in Boost 1.74.0
|
Thx for the contribution @arkamar. |
|
We are talking about MariaDB 10.6 and 10.11 with respect to this PR. I will apply this patch locally. My main intention with this PR is to increase awareness that the Boost 1.85 dropped some deprecated code. Maybe other downstreams might find this PR useful as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gentoo users cannot compile MariaDB with columnstore because the oldest available Boost version in Gentoo is 1.85, see https://bugs.gentoo.org/932735. Migration seems to be straightforward, however, I noticed PR #3394, therefore, I am not sure, if this change is feasible for others.
I have set the base to
develop-6because I did the migration for Mariadb 10.6.21 and 10.11.11, both versions compile and pass tests. The change seems to apply todevelopcleanly as well, but I didn't test it properly yet.Boost 1.85 removed some deprecated code in filesystem module which is still used in columnstore:
normalizemethod was removed and users are suggested to replace it withlexically_normalmethod, which was introduced in Boost 1.60.0.copy_optionwas removed in favor ofcopy_options(note the trailing 's'), but enum values were renamed. Namely,fail_if_existsis replaced withnoneandoverwrite_if_existsis replaced withoverwrite_existing. Thecopy_optionswas introduced in Boost 1.74.0