Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed (Build-on : GNU/Linux) -> target_file: PreferencesDialogStyle.cpp, target_line: 571 #408

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

baldeuniversel
Copy link
Contributor

Hi !

Here a bug :

bug_flamerobin_0 9 12

I fixed it by modifying this file PreferencesDialogStyle.cpp, the affected line is (line 571) :
style->setFontSize(atoi(fontSizeComboBoxM->GetString(fontSizeComboBoxM->GetSelection())));

Here the update :

style->setFontSize(atoi(fontSizeComboBoxM->GetString(fontSizeComboBoxM->GetSelection()).ToStdString().c_str()));


Build-on : GNU/Linux

wx-config --version
3.2.6

…71, build_on: GNU/Linux, wxWedgets_v: 3.2.6\}
@arvanus arvanus merged commit a0c8372 into mariuz:master Feb 14, 2025
4 checks passed
@baldeuniversel
Copy link
Contributor Author

Hi !

Here a release for Linux system (already tested on GNU/Linux successfully).

FlameRobin 0.9.12 : build-for-linux

@baldeuniversel
Copy link
Contributor Author

And a snap version here :

https://snapcraft.io/flamerobin

@arvanus
Copy link
Collaborator

arvanus commented Feb 19, 2025

How do you generate the .deb?
It would be nice to have a .deb or at least a compiled .tar.gz generated automatically in our CICD

@baldeuniversel
Copy link
Contributor Author

baldeuniversel commented Feb 20, 2025

How do you generate the .deb? It would be nice to have a .deb or at least a compiled .tar.gz generated automatically in our CICD

Note :
A workflow file focused on Linux needs to be created.


In the main directory(the root), two directories(with some subdirectories) can be added like this :
(A) templates -> trees -> deb -> flamerobin
(B) build-for -> linux

On the (A) tree , I can add some templates files, and some algos that will be used after the execution of this command make install (need a virtual machine to perform this operation), and during the installation of the .deb package.

For sure, before executing the make install command, it's necessary to indicate a well-known prefix installation path like this -> /usr/local. After the execution of the make install command (successfully), a script or algorithm should be executed to retrieve the Debian templates, make modifications (for example, set the correct flameRobin version, etc.), assemble them with the directories resulting from the installation, and then build everything into a valid .deb package, then upload the result to (B) tree.

Essentially, these are the scenarios and processes to be carried out.

@baldeuniversel
Copy link
Contributor Author

baldeuniversel commented Feb 21, 2025

Hi !

I created a workflow file and implemented some templates and algos allowing to build, construct and install the deb resulting package (specially the flamerobin app).

Here the status of the build :
flamerobin for Linux -> workflow build status

A pull request is pending for a merge.

@baldeuniversel
Copy link
Contributor Author

Hi !

I updated the workflow file (linux-build.yml) to ensure that, after building the flamerobin app, the upstream files [Build/*] are used instead of the copied custom files.

Here the status of the new build. (Build successfully)

Tested on Ubuntu 24.04 successfully.

A pull request is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants