Clarify return float/int type for core.Composition.reduced_composition
and siblings, minor type clean up for core.Composition
#4265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
core.Composition.reduced_composition
and siblings,factor
returned byreduce_formula
would be int instead of float (as a union type of float | int):pymatgen/src/pymatgen/core/composition.py
Lines 1345 to 1348 in 296a0ec
core.Composition
reduce_formula
is not covered by test