Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to get the Pearson symbol to SpaceGroupAnalyzer #4281

Merged
merged 8 commits into from
Mar 7, 2025
Merged

Add method to get the Pearson symbol to SpaceGroupAnalyzer #4281

merged 8 commits into from
Mar 7, 2025

Conversation

CompRhys
Copy link
Contributor

@CompRhys CompRhys commented Feb 4, 2025 •
edited
Loading

Summary

Add a simple convenience method to SGA to return the Pearson Symbol.

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

@mkhorton mkhorton enabled auto-merge (squash) February 10, 2025 03:51
@mkhorton
Copy link
Member

Thanks Rhys!

auto-merge was automatically disabled March 1, 2025 17:10

Head branch was pushed to by a user without write access

@mkhorton mkhorton enabled auto-merge (squash) March 7, 2025 02:38
@mkhorton mkhorton merged commit 9523e3c into materialsproject:master Mar 7, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkhorton mkhorton mkhorton approved these changes

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CompRhys @mkhorton @shyuep