patch to allow pyzeo to work #4315
Open
+62
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great thanks. Can you add / enable some unittests to check that this is working? Thanks. |
|
You would also need to add it as an optional dependency, thanks for the edit! |
… into zeopp_pyzeo-patch
… into zeopp_pyzeo-patch
|
Note that even with the patch one would still need to manually install zeo++, i've added some logic to the test.yaml in the workflow for this, but can't really test it on my end. The tests pass if zeo++ is installed. Historically testing the zeo++ plugin was just skipped for this reason, but maybe it can be automated and included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
Pyzeo is a more maintained version of the cython but has different imports. This small patch allows users to swap out zeo++ with pyzeo.